Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh 2588/what is safe screen #2611

Merged
merged 21 commits into from
Sep 6, 2022
Merged

Gh 2588/what is safe screen #2611

merged 21 commits into from
Sep 6, 2022

Conversation

biafra23
Copy link
Contributor

@biafra23 biafra23 commented Sep 5, 2022 •
edited
Loading

Handles #2588

Changes proposed in this pull request:
image

@biafra23 biafra23 self-assigned this Sep 5, 2022
@biafra23 biafra23 marked this pull request as ready for review September 6, 2022 08:07
@DmitryBespalov
Copy link
Contributor

To remove the border from navigation bar:

ViewControllerFactory.removeNavigationBarBorder()

@DmitryBespalov
Copy link
Contributor

@DmitryBespalov check the scroll view setup

@biafra23
Copy link
Contributor Author

biafra23 commented Sep 6, 2022 •
edited
Loading

To remove the border from navigation bar:
ViewControllerFactory.removeNavigationBarBorder()

I could not find this method in main branch, so I implemented my own. See: https://github.com/safe-global/safe-ios/pull/2611/files#diff-d7820cd68cc0e0514e244d1e60f177dc0528083cdc4be5901aab445556385da7R88

@biafra23 biafra23 merged commit 586a26d into main Sep 6, 2022
@biafra23 biafra23 deleted the GH-2588/what-is-safe-screen branch September 6, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitryBespalov DmitryBespalov DmitryBespalov approved these changes

Assignees

@biafra23 biafra23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biafra23 @DmitryBespalov